Accessibility contrast fixes #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lidel -- now that we've got the slightly darker |
jessicaschilling
changed the title
lidel
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
@jessicaschilling LGTM! I tweaked Language modal (Settings → change language) too:
Before
After
I am not sure why we have "English" multiple times, looks like a bug, but its not a blocker for this PR.
|
Thanks for finding the one I missed! |
|
Filled issue for the problem with labels: #1471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates higher-contrast (darker)
tealvalue into Web UIaquatext and backgrounds totealfor accessibility contrast purposesNote that this does change the overall tone of the look/feel subtly. We may want to think about adding more
tealback in to non-accessibility-critical elements like borders and highlights in future work.Closes #1379